Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Jumanji environment spec access in examples #24

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Fix Jumanji environment spec access in examples #24

merged 1 commit into from
Apr 16, 2024

Conversation

rk1a
Copy link
Contributor

@rk1a rk1a commented Apr 15, 2024

Jumanji turned specs into cached properties making them non-callable: instadeepai/jumanji@1f38fe6
This PR fixes the example notebooks by updating the set_up_experiment function accordingly.

@CLAassistant
Copy link

CLAassistant commented Apr 15, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

sash-a
sash-a approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @rk1a 🔥!

Sorry we made that change in jumanji and forgot to change stuff here, as soon as you sign the CLA we can merge 😄

@sash-a sash-a merged commit 40a64e5 into instadeepai:main Apr 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sash-a sash-a sash-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rk1a @CLAassistant @sash-a