fix: be explicit about squeeze dim in prioritised sampling to avoid flattening (1,1) arrays #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the following snippet will fail:
because of this line:
flashbax/flashbax/buffers/sum_tree.py
Line 211 in b556e15
If the
sample_batch_size
is 1,query_values
is shape(1,1)
, which squeezes to()
.Instead we must be explicit about the squeeze dim.