fix: error when vault's rel_dir is a parent directory #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arent directory problems.
|
@jcformanek maybe you could take a quick look at this, to approve? Simple test is to have your vault in the parent directory ( |
|
Why are we type ignoring? |
|
@EdanToledo apologies, solved this elsewhere with #35. Need to update here :) |
…/flashbax into fix/support_parent_rel_paths
|
@EdanToledo fixed. Just waiting to confirm that mypy is now happy 🚀 |
|
@EdanToledo when you're ready: 🤾🏻♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue raised here, with a very simple fix actually—just normalise the path before processing.
We could look at having an
abs_pathargument too, but I don't want to change the API or anything right now. This is an easy change, that simply allows the parent directory (..) to be part of therel_dir.