prioritised_trajectory_buffer: allow adding max_length_time_axis #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love for this to be checked in. Actually ran into this bug myself. |
|
Hi @garymm, I don't have privileges to merge this in anymore. @sash-a you know who can help verify this? Only comment I have on the PR is we should probably check if the sampling of the data is fine if the entire buffer is added. I remember when making it there was some funky issue with adding the entire buffer but it's possible we fixed that issue. I might be getting my wires crossed as well as it could've been regarding sampling the entire buffer. |
|
I'm happy to review, thanks for this @garymm 😄 Agree with @EdanToledo, can you add a call to sample in your test and then I think it's good to go |
|
@sash-a done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.