Pass max_length_time_axis instead of max_size #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickvangelderen
force-pushed
the
mick/pass-max-length-time-axes-instead-of-max-size
branch
from
f3cad12 to
89cd3a3
Compare
Makes it so that the warning: ``` Setting max_size dynamically sets the `max_length_time_axis` to be `max_size`//`add_batch_size = .*` ``` will no longer be triggered by legitimate use of `create_flat_buffer` and `make_prioritised_flat_buffer`.
mickvangelderen
force-pushed
the
mick/pass-max-length-time-axes-instead-of-max-size
branch
from
89cd3a3 to
d085f09
Compare
This was referenced Nov 12, 2024
|
|
mickvangelderen
deleted the
mick/pass-max-length-time-axes-instead-of-max-size
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #41
Pass max_length_time_axis instead of max_size
Makes it so that the warning:
will no longer be triggered by legitimate use of
create_flat_bufferandmake_prioritised_flat_buffer.