Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Peg Solitaire env #201

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

George-Ogden
Copy link
Contributor

This merge request contains code for a new environment: peg solitaire

@carlosgmartin
Copy link

carlosgmartin commented Nov 2, 2023

@George-Ogden What's the status of this PR? Anything I could help with?

@George-Ogden
Copy link
Contributor Author

Hi @carlosgmartin
Is there a plan to merge this? If so, I can rebase onto main

@carlosgmartin
Copy link

I guess @clement-bonnet or @sash-a needs to approve it?

@George-Ogden
Copy link
Contributor Author

I've merged main and fixed the typing, linting and testing issues.

@clement-bonnet
Copy link
Collaborator

Hi @George-Ogden , thank you for the contribution! I think the last discussion led to questions about whether it was best for Solitaire to be integrated into Jumanji or somewhere else given its lack of initial state distribution and stochasticity.
We are currently trying to wrap up Pacman, Sokoban, SlidingTilePuzzle, and FlatPack for the camera-ready version of the paper and the 0.4 release. Therefore, we will loop back on Solitaire after the release, and hope to get back to you soon 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants