Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/update diagnose_data_errors #62

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JemmaLDaniel
Copy link
Contributor

What?

This PR does the following:

  1. brings diagnose_data_errors.py up-to-date with current Mava JSON logging, and
  2. fixes some typos and formatting errors in docstrings and error logs.

Why?

  1. Currently, checking concatenated JSON data falsely errors, citing non-identical metrics across the JSON file, but plotting can execute without error!
  2. Error logs are written with unnecessary tabs that affect the printing of the log, and some print statements and docstring contain grammatical errors.

How?

  1. check_metric() is modified to remove elapsed_time, which prevents the false error message.

@JemmaLDaniel JemmaLDaniel self-assigned this May 2, 2024
@JemmaLDaniel JemmaLDaniel added the bug Something isn't working label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant