Add preliminary support for Merlin detector #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I verified the data with the data displayed in the merlin software The first byte of the framedata has to be skipped when reading the data to extract the correct metadata and avoid off-by-one error when converting the buffer into a numpy array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds preliminary support for the Merlin detector.
It implements a new camera interface to interact with the Merlin software over a socket connection. The new interface can be tested by setting
interface: merlinin yourcamera.yaml. See:instamatic/config/camera/merlin.yamlfor an example.What is working:
Limitations:
Addresses #62