Decouple from basictracer and store IDs as signed integers #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide our own: - TracerOptions - RawSpan - SpanContext Add more tests.
pglombardo
changed the title
- Drop RawSpan - Unify all span functionality under spanS - Introduct jsonSpan - Now store and handle IDs at signed 64bit integers - Standardize on instana.Recorder - Move getSpanKind, getSpanTag and similar under spanS - Update tests to follow changes
- Lower case name for things that shouldn't be exported - More comments for things that are exported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basictracer implementation of the rawspan stores integers as unsigned which conflicts with Instana requirements. We need to decouple from basictracer and go our separate ways.
We should also revalidate ID generation and add tests to validate.
TracerOptionsUnify Span management
RawSpan,RPCDataspanSjsonSpanandjson*sub structsinstana.RecordergetSpanKind,getSpanTagand similar underspanS