Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Span Kind cleanup and improvements #62

Merged
merged 2 commits into from
Feb 15, 2019
Merged

Span Kind cleanup and improvements #62

merged 2 commits into from
Feb 15, 2019

Conversation

pglombardo
Copy link
Contributor

Better handling & reporting of the type and k fields in the reported spans.

This replaces #61

@pglombardo pglombardo requested a review from steveww February 15, 2019 13:42
@pglombardo
Copy link
Contributor Author

A Trace with an intermediate span:
screen shot 2019-02-15 at 14 43 34

Going to add/update an example that illustrates how to create intermediate spans as well.

@pglombardo
Copy link
Contributor Author

And updated the ot-simple example app with an intermediate span
screen shot 2019-02-15 at 15 08 49

steveww
steveww reviewed Feb 15, 2019
View reviewed changes
Copy link
Contributor

@steveww steveww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pglombardo pglombardo merged commit 56457d4 into master Feb 15, 2019
@pglombardo pglombardo deleted the update-reported-sdk-fields branch February 15, 2019 16:27
@pglombardo pglombardo mentioned this pull request Feb 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveww steveww steveww left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pglombardo @steveww