Job 312 #459
Merged
Job 312 #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
…unittest' Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
GSVarsha
reviewed
Oct 10, 2023
There was a problem hiding this comment.
Should we implement the tearDown method to release the resources? (pymongo connection)
|
Can we move this import statement to the beginning of the file just to be consistent? |
|
Is this relevant anymore provided that we've removed |
Done |
For obvisous reasons it can't overtake the environment variable settings, and it's dependent import, but I have moved it to the beginning as much as possible. |
Renamed. |
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.