Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix autotrace detection #462

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Fix autotrace detection #462

merged 5 commits into from
Oct 26, 2023

Conversation

Ferenc-
Copy link
Collaborator

@Ferenc- Ferenc- commented Oct 20, 2023

No description provided.

pvital
pvital requested changes Oct 23, 2023
View reviewed changes
instana/collector/helpers/runtime.py Outdated Show resolved Hide resolved
tests/platforms/test_host_collector.py Outdated Show resolved Hide resolved
tests/platforms/test_host_collector.py Outdated Show resolved Hide resolved
@Ferenc-
fix(collector): Update detection of AutoTrace (injector) to current m…
ddb5908 
…ethod

Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
@Ferenc-
test: Check instrumentation method in host collector tests
9a6c8ac 
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
@Ferenc-
test: Cover AutoTrace and Autowrap instrumentation methods
a554924 
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
@Ferenc-
refactor(test): Assert expected snapshot packages in a loop
ea20ac7 
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
@Ferenc-
refactor(runtime): Use a constant for the deprecated installation path
a0d4434 
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
@Ferenc- Ferenc- requested a review from pvital October 25, 2023 14:53
@Ferenc- Ferenc- requested a review from pvital October 26, 2023 10:07
pvital
pvital approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ferenc- Ferenc- merged commit 5212cf0 into master Oct 26, 2023
11 checks passed
@Ferenc- Ferenc- deleted the fix-autotrace-detection branch October 26, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSVarsha GSVarsha GSVarsha left review comments

@pvital pvital pvital approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ferenc- @pvital @GSVarsha