Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest urllib3 without secure extra #479

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Use latest urllib3 without secure extra #479

merged 2 commits into from
Dec 7, 2023

Conversation

GSVarsha
Copy link
Contributor

@GSVarsha GSVarsha commented Dec 7, 2023 •
edited
Loading

Signed-off-by: Varsha GS varsha.gs@ibm.com

  • Use urllib3>=1.26.5
  • Remove secure extra feature (more info)

@GSVarsha
- use urllib3>=1.26.18
cc89a90 
- remove secure extra feature

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha self-assigned this Dec 7, 2023
@GSVarsha GSVarsha added the dependencies Pull requests that update a dependency file label Dec 7, 2023
Ferenc-
Ferenc- reviewed Dec 7, 2023
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@GSVarsha
use urllib3>=1.26.5
df68d7b 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
pvital
pvital approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@GSVarsha GSVarsha requested a review from Ferenc- December 7, 2023 14:57
Ferenc-
Ferenc- approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Ferenc- Ferenc- merged commit 01ce095 into master Dec 7, 2023
12 checks passed
@Ferenc- Ferenc- deleted the update-urllib3 branch December 7, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ferenc- Ferenc- Ferenc- approved these changes

@pvital pvital pvital approved these changes

Assignees

@GSVarsha GSVarsha

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GSVarsha @pvital @Ferenc-