Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The spec doesn't set upper limit for ec=1 if code>=500 #482

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

Ferenc-
Copy link
Collaborator

@Ferenc- Ferenc- commented Dec 12, 2023

Quote from the spec:

For HTTP exit and entry spans alike, if a full request/response cycle has happened (which implies that an HTTP status code is present): If the HTTP status code is >= 500, the associated span MUST be marked as an error via span.ec.

This means that there is no upper limit, and this should apply to custom status codes as well, which might be above 511, or even 599.

Copy link

@tamarastanojevic tamarastanojevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, anything greater or equal than 500 must be considered as error. LGTM 👍🏻

Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ferenc- Ferenc- merged commit f6a06be into master Dec 14, 2023
12 checks passed
@Ferenc- Ferenc- deleted the fix-error-codes branch December 14, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants