Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test infra updates #483

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Test infra updates #483

merged 3 commits into from
Dec 18, 2023

Conversation

pvital
Copy link
Member

@pvital pvital commented Dec 13, 2023

This PR contains updates and changes to improve and synchronize the test infrastructure.

@GSVarsha
Copy link
Contributor

Hey Paulo, are the following intentional?

Ferenc-
Ferenc- approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@Ferenc-
Copy link
Collaborator

Ferenc- commented Dec 14, 2023

It's not just the version which is different, they are entirely different images, cimg/postgres vs postgres. They contain different things and have different lifecycles. See https://circleci.com/docs/circleci-images/

@pvital
Copy link
Member Author

pvital commented Dec 14, 2023 •
edited
Loading

@GSVarsha, yes, all of the changes are intentional :-D

We are using specific version of services in the config.yml file and the latest available version of services in the docker-compose.yml file.

So, the docker-compose.yml file is intended to support the services for the local tests during the development using pytest. As @Ferenc- has mentioned, the images from the CircleCI config and this docker-compose file differ. Still, they could be set to use the latest versions since we are not dependent, or interested, on the server versioning but on the clients.

The 0 in passw0rd

Always use numbers (and symbols) in your dummy test passwords. ;-)

@pvital
chore: Update pubsub service on docker-compose.yml
02a019a 
Update the pubsub service for the development docker-compose.yml file compatible with the CircleCI and current tests configuration.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
chore: Set docker-compose images to latest version
f9ad1d5 
Since our development is not based on the server versioning, but the
Python client one, let's use the latest versions of the container
images configured in the docker-compose file.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
chore(ci+tests): Set PostgreSQL password.
87c25b9 
Following the necessary requirements for the most recent versions of the
PostgreSQL, let's set a simple and dummy password.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
GSVarsha
GSVarsha approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Ferenc and Paulo for the explanation.
Looks good to me then!

@pvital pvital merged commit 6cd0063 into master Dec 18, 2023
12 checks passed
@pvital pvital deleted the test_infra_updates branch December 18, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSVarsha GSVarsha GSVarsha approved these changes

@Ferenc- Ferenc- Ferenc- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvital @GSVarsha @Ferenc-