Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tests): Remove superfluous imports #504

Merged
merged 4 commits into from
Feb 15, 2024
Merged

refactor(tests): Remove superfluous imports #504

merged 4 commits into from
Feb 15, 2024

Conversation

GSVarsha
Copy link
Contributor

Follow up PR for #503

Copy link
Collaborator

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Perhaps a few extra lines could be shedded.

instana/collector/base.py Show resolved Hide resolved
instana/util/ids.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
- remove PY2

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha merged commit a8aad4d into master Feb 15, 2024
12 checks passed
@GSVarsha GSVarsha deleted the cleanup-2.0 branch February 15, 2024 10:29
@GSVarsha GSVarsha added this to the H1-2024 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants