Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanic: capture responseHeadersOnEntrySpans #505

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Conversation

GSVarsha
Copy link
Contributor

Sanic: capture responseHeadersOnEntrySpans

Signed-off-by: Varsha GS varsha.gs@ibm.com

@GSVarsha GSVarsha self-assigned this Feb 14, 2024
@GSVarsha GSVarsha added the wip work in progress label Feb 14, 2024
.circleci/config.yml Outdated Show resolved Hide resolved
@GSVarsha GSVarsha marked this pull request as draft February 15, 2024 08:19
@GSVarsha GSVarsha marked this pull request as ready for review February 15, 2024 09:26
@GSVarsha GSVarsha removed the wip work in progress label Feb 15, 2024
@GSVarsha GSVarsha requested a review from pvital February 15, 2024 09:48
@GSVarsha GSVarsha added the Do not merge Depends on another PR label Feb 15, 2024
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha removed the Do not merge Depends on another PR label Feb 15, 2024
Copy link
Collaborator

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@GSVarsha GSVarsha merged commit f393063 into master Feb 18, 2024
12 checks passed
@GSVarsha GSVarsha deleted the capture_header_sanic branch February 18, 2024 10:11
@GSVarsha GSVarsha added this to the H1-2024 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants