ci: Include testing with latest starlette version #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSVarsha
force-pushed
the
latest-starlette-ci
branch
from
046f93a
to
aff04bc
Compare
GSVarsha
force-pushed
the
latest-starlette-ci
branch
2 times, most recently
from
29e25fe
to
c876a6d
Compare
Ferenc-
requested changes
Mar 18, 2024
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
GSVarsha
force-pushed
the
latest-starlette-ci
branch
from
c876a6d
to
44925d8
Compare
|
Modified the master branch protection rules to have |
ERROR: file or directory not found: tests/frameworks/test_gevent.py tests/frameworks/test_starlette.py Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Ferenc-
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Run both starlette and gevent tests together in a single job
Why
PR from FastAPI to include the latest starlette version is still not merged
Reference
slack thread: https://instana.slack.com/archives/C05M4RNDPLZ/p1709204882315999