Build migration to pyproject.toml #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvital
force-pushed
the
build_migration_to_pyproject.toml
branch
from
d4f984f
to
cebb8e2
Compare
Ferenc-
reviewed
May 6, 2024
GSVarsha
reviewed
May 10, 2024
To follow the new build system standardized by PEP 517 and PEP 660, this commit changes the production code to be under the `src` directory and has a cleaner project structure. Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
pvital
force-pushed
the
build_migration_to_pyproject.toml
branch
from
cebb8e2
to
8891376
Compare
Ferenc-
reviewed
May 22, 2024
PEP 621 and PEP 631 standardized `pyproject.toml` as the new normal for Python packages instead of `setup.py`. PEP 517 and PEP 660 created standards for Python build systems. This commit removes the `setup.py` file and creates a `pyproject.toml` one to deal with the new packaging standards. Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
pvital
force-pushed
the
build_migration_to_pyproject.toml
branch
from
8891376
to
58c3580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests changing the current build and package files to the latest standard Python building system. It prevents issues with the Instana package not being installed or built if the package
wheelis not installed in the running environment (see pypa/pip#8559), which is common in fresh environments with recentpipversions.To solve that, the suggestion is to use
pyproject.tomlinstead ofsetup.pyas building and packaging files. PEP 621 and PEP 631 standardizedpyproject.tomlas the new normal for Python packages instead ofsetup.py. PEP 517 and PEP 660 created standards for Python build systems.This PR:
srcdirectory;setup.py; andpyproject. tomlfile to be the new build and package file.The new
pyproject. tomlfile uses Hatchling as the default build-backend, and it must be installed in your system to build the package.