Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Change to available pubsub-emulator image #535

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

Ferenc-
Copy link
Collaborator

@Ferenc- Ferenc- commented May 28, 2024

No description provided.

Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but we have to be careful when using non-official images here, even if for testing purposes only.

In the future, we can investigate the use of the cloud CLI and the emulator option, as documented here.

@Ferenc- Ferenc- merged commit 67b43e7 into master May 28, 2024
13 checks passed
@Ferenc- Ferenc- deleted the pubsub-emulator-image branch May 28, 2024 09:48
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants