Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop 3.7 support #542

Merged
merged 1 commit into from
Jun 13, 2024
Merged

chore: Drop 3.7 support #542

merged 1 commit into from
Jun 13, 2024

Conversation

Ferenc-
Copy link
Collaborator

@Ferenc- Ferenc- commented Jun 12, 2024

This is needed for multiple reasons,
most pressing is that the importlib.metadata is only available in 3.8, and that would be needed to fix deprecation warnings about pkg_resources.

@Ferenc- Ferenc- requested review from pvital and GSVarsha June 12, 2024 09:35
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider removing 3.7 from here as well?

@Ferenc-
Copy link
Collaborator Author

Ferenc- commented Jun 12, 2024

Should we consider removing 3.7 from here as well?

Yes, that should have been removed long ago.

Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we handle this?
Somehow 3.7 is getting picked by the CI runs.

Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove all the branching for 3.7?

Screenshot 2024-06-12 at 4 02 56 PM Screenshot 2024-06-12 at 4 04 48 PM

This is needed for multiple reasons,
most pressing is that the `importlib.metadata` is only available in 3.8,
and that would be needed to fix deprecation warnings about `pkg_resources`.

Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you can also remove the tests/requirements-307.txt file in this PR.

@Ferenc- Ferenc- force-pushed the drop-37 branch 2 times, most recently from 2ac9bbc to a9b50ec Compare June 12, 2024 15:01
@Ferenc- Ferenc- requested review from GSVarsha and pvital June 12, 2024 15:18
tests/requirements-308.txt Outdated Show resolved Hide resolved
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GSVarsha GSVarsha merged commit e833571 into master Jun 13, 2024
12 checks passed
@GSVarsha GSVarsha deleted the drop-37 branch June 13, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants