Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codebase: added pre-commit-feature and ruff linter #642

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

CagriYonca
Copy link
Contributor

Implemented pre-commit-feature and ruff linter. The codebase will be cleaner, easier and in better shape than before.

@CagriYonca CagriYonca self-assigned this Oct 4, 2024
@CagriYonca CagriYonca force-pushed the pre-commit-feature branch 3 times, most recently from 40b6e6d to 9fe367b Compare October 10, 2024 16:32
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no way to review 129 files. Please only commit the pre-commit config file and all the changes to the production code we commit as we touch it in the future.

Also, add the packages ruff and pre-commit as dependencies in the [project.optional-dependencies][dev] list in the pyproject.toml file.

@CagriYonca CagriYonca force-pushed the pre-commit-feature branch 5 times, most recently from f83ad96 to e6b9a85 Compare October 18, 2024 13:20
@CagriYonca CagriYonca force-pushed the pre-commit-feature branch 3 times, most recently from 8e1f3f3 to 1ea8d5a Compare October 24, 2024 10:40
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few (more) requests. 😬

pyproject.toml Show resolved Hide resolved
tests/requirements.txt Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
Signed-off-by: Cagri Yonca <cagri@ibm.com>
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@CagriYonca CagriYonca merged commit 8afae10 into master Oct 24, 2024
12 of 13 checks passed
@CagriYonca CagriYonca deleted the pre-commit-feature branch October 24, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants