-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codebase: added pre-commit-feature and ruff linter #642
Conversation
40b6e6d
to
9fe367b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no way to review 129 files. Please only commit the pre-commit config file and all the changes to the production code we commit as we touch it in the future.
Also, add the packages ruff
and pre-commit
as dependencies in the [project.optional-dependencies][dev]
list in the pyproject.toml
file.
f83ad96
to
e6b9a85
Compare
8e1f3f3
to
1ea8d5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few (more) requests. 😬
Signed-off-by: Cagri Yonca <cagri@ibm.com>
1ea8d5a
to
645cd35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
Implemented pre-commit-feature and ruff linter. The codebase will be cleaner, easier and in better shape than before.