Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(currency): install google-cloud-storage v2.18.2 separately for python 3.11 and python 3.12 #662

Closed
wants to merge 1 commit into from
Closed

fix(currency): install google-cloud-storage v2.18.2 separately for python 3.11 and python 3.12 #662

wants to merge 1 commit into from

Conversation

CagriYonca
Copy link
Contributor

No description provided.

@CagriYonca CagriYonca requested review from pvital and GSVarsha October 28, 2024 13:19
@CagriYonca CagriYonca self-assigned this Oct 28, 2024
pvital
pvital requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait. You have just removed the job that runs GoogleCloud in the commit b7d66d1.
Why you are re-introducing it again?

@CagriYonca CagriYonca force-pushed the fix_requirements branch 2 times, most recently from 5567b02 to fb92a6d Compare October 28, 2024 14:26
@CagriYonca CagriYonca requested a review from pvital October 28, 2024 18:31
pvital
pvital approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@CagriYonca CagriYonca requested a review from a team as a code owner October 29, 2024 15:42
GSVarsha
GSVarsha reviewed Oct 30, 2024
View reviewed changes
GSVarsha
GSVarsha requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CagriYonca, I don't quite understand the intention behind this PR.

This change doesn't reflect the title of the PR: "run google-cloud-storage v2.18.2 separately for python 3.11".

The commit message: combined requirement files into one file and updated pipelines also refers to something else.

@CagriYonca
Copy link
Contributor Author

CagriYonca commented Oct 30, 2024 •
edited
Loading

Hi @CagriYonca, I don't quite understand the intention behind this PR.

This change doesn't reflect the title of the PR: "run google-cloud-storage v2.18.2 separately for python 3.11".

The commit message: combined requirement files into one file and updated pipelines also refers to something else.

It's just a fix for fix_requirements branch, I'll update the commit message right now

@CagriYonca CagriYonca force-pushed the fix_requirements branch 2 times, most recently from e937ecb to 4a6e945 Compare October 30, 2024 09:06
@CagriYonca CagriYonca changed the title fix(currency): run google-cloud-storage v2.18.2 separately for python 3.11 fix(currency): installing google-cloud-storage v2.18.2 separately for python 3.11 Oct 30, 2024
@CagriYonca CagriYonca requested a review from GSVarsha October 30, 2024 09:07
@CagriYonca CagriYonca changed the title fix(currency): installing google-cloud-storage v2.18.2 separately for python 3.11 fix(currency): install google-cloud-storage v2.18.2 separately for python 3.11 Oct 30, 2024
GSVarsha
GSVarsha requested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry here to prevent running gcs tests on the runtime jobs.

@CagriYonca CagriYonca requested a review from GSVarsha November 4, 2024 13:43
@CagriYonca CagriYonca changed the title fix(currency): install google-cloud-storage v2.18.2 separately for python 3.11 fix(currency): install google-cloud-storage v2.18.2 separately for python 3.11 and python 3.12 Nov 5, 2024
GSVarsha
GSVarsha approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CagriYonca
currency(cloudstorage): added separate task to circleci and tekton fo…
65bc75f 
…r python3.11 and python3.12

Signed-off-by: Cagri Yonca <cagri@ibm.com>
@CagriYonca
Copy link
Contributor Author

I'm closing this PR. The PR below solves dependency problems with google-cloud package for Python 3.11 and 3.12:
#667

@CagriYonca CagriYonca closed this Nov 11, 2024
@CagriYonca CagriYonca deleted the fix_requirements branch February 6, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvital pvital pvital approved these changes

@GSVarsha GSVarsha GSVarsha approved these changes

Assignees

@CagriYonca CagriYonca

Labels
currency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CagriYonca @pvital @GSVarsha