Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not print "Starting Instana instrumentation" when INSTANA_DISABLED=true #268

Closed
breunigs opened this issue Mar 25, 2022 · 1 comment · Fixed by #269
Closed

do not print "Starting Instana instrumentation" when INSTANA_DISABLED=true #268

breunigs opened this issue Mar 25, 2022 · 1 comment · Fixed by #269

Comments

@breunigs
Copy link

Problem Description

This line

::Instana.logger.info "Stan is on the scene. Starting Instana instrumentation version #{::Instana::VERSION}"

is logged even if Instana is intentionally disabled. It would be much appreciated if this could also honor INSTANA_DISABLED like done elsewhere and adjust the wording slightly to remove any confusion as to whether Instana instrumentation is on or off.
unless ENV.fetch('INSTANA_DISABLE', false)

Minimal, Complete, Verifiable, Example

export INSTANA_DISABLED=true
cd some-ruby-app
bundle exec rails s

Gemfile.lock

# instana=1.209.0.pre1

Ruby Version

not relevant
@hmadison
Copy link
Collaborator

Hi @breunigs

I've opened #269 to resolve this and should have out later today.

Thanks,
Hunter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants