Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing tests. The failures for rails v > 6.1 #391

Merged
merged 6 commits into from
Jun 24, 2024

Conversation

arjun-rajappa
Copy link
Contributor

… test app was not being initialised. So Instana activator for action view was not being triggered properly.

… test app was not being initialized. So intana activator weas not beeing triggered properly.

Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have a shorter PR title and put all the details in the description?

Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI tests for rails are failing for this PR.

@arjun-rajappa arjun-rajappa changed the title fix failing tests. The failures for rails v > 6.1 was because the rack… fix failing tests. The failures for rails v > 6.1 Jun 19, 2024
@arjun-rajappa arjun-rajappa requested a review from GSVarsha June 19, 2024 10:56
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
@arjun-rajappa
Copy link
Contributor Author

The CI tests for rails are failing for this PR.

Can you have a shorter PR title and put all the details in the description?

The CI tests for rails are failing for this PR.

The CI tests for rails are failing for this PR.

All tests are passing

Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Copy link
Contributor

@Ferenc- Ferenc- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Ferenc- Ferenc- merged commit ef485ce into master Jun 24, 2024
170 checks passed
@Ferenc- Ferenc- deleted the fix-failing-action-view-tests branch June 24, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants