Fix sensor freezing worker thread #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the connection is lost after 60 seconds using asynchronous timer task. Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
arjun-rajappa
force-pushed
the
fix-sensor-freezing-worker-thread
branch
from
f72fe3f to
c4dea02
Compare
pvital
requested changes
Nov 6, 2024
lib/instana.rb
Outdated
| @@ -17,6 +17,6 @@ | |||
| ::Instana::Activator.start | |||
| ::Instana.agent.spawn_background_thread | |||
|
|
|||
| ::Instana.logger.info "Stan is on the scene. Starting Instana instrumentation version #{::Instana::VERSION}" | |||
| ::Instana.logger.info "Stan is on the scene. Starting Instana instrumentation version #{::Instana::VERSION}" if ::Instana.agent.ready? | |||
There was a problem hiding this comment.
Indepentently if the Agent is ready, I think it's interesting to log this message.
I would keep it as before and add extra log messages if the Agent is not reached or is not ready to accept spans.
There was a problem hiding this comment.
There was a problem hiding this comment.
So will remove this condition
…done in host_agent.rb Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a timeout mechanism for agent connection and retrying if the connection is lost after 60 seconds using asynchronous timer task