A way provide user to hide color history #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodik82
requested changes
Oct 23, 2020
| @@ -179,7 +179,7 @@ export class HoloColorPicker extends React.PureComponent { | |||
| activeOpacity={0.7} | |||
| /> | |||
| } | |||
| {!oldColor && | |||
| {!oldColor && this.props.hideOldColor === false && | |||
There was a problem hiding this comment.
I believe here the prop does not make sense, since it has the setting hideOldColor to true has the same effect as not setting oldColor.
And missing default prop with === would change the default behaviour, however I believe it shouldn't be here at all (if I am not mistaken)
| @@ -264,7 +264,8 @@ export class TriangleColorPicker extends React.PureComponent { | |||
| </View> | |||
| } | |||
| </View> | |||
| <View style={[styles.colorPreviews, computed.colorPreviews]}> | |||
| { this.props.hideOldColor === false && | |||
There was a problem hiding this comment.
and here... I believe the property won't hide old color but "both" colors - maybe wrong name? hideColorPreview?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.