Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Asterisk's public IP in SIP INVITEs #877

Closed
matiasgarciaisaia opened this issue Jul 27, 2020 · 2 comments · Fixed by instedd/verboice-asterisk#1
Closed

Use Asterisk's public IP in SIP INVITEs #877

matiasgarciaisaia opened this issue Jul 27, 2020 · 2 comments · Fixed by instedd/verboice-asterisk#1

Comments

@matiasgarciaisaia
Copy link
Member

Asterisk is currently sending INVITEs using its container's private IP address in the SIP INVITE (on the o= [...] IN IP4 ${THE_IP} line).

The public IP is correctly being set on the Via: header, but some ISPs prefer to have the public IP in the previously mentioned line too.

To change this, we have to make Verboice write a media_address=54.236.234.104 line in the pjsip.conf file, just like we're currently doing with external_media_address and external_signaling_address.

matiasgarciaisaia added a commit that referenced this issue Jul 27, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
It's needed to correctly set Asterisk's public IP address in the
`o=` line of the SIP INVITE.

See #877 for context
@matiasgarciaisaia
Copy link
Member Author

Update: Verboice is not writing the external_media_address nor external_signaling_address - we're manually doing it in the instances were it's needed.

We should probably make that automatic.

I've updated the config file's template in 59a78f3 for now.

matiasgarciaisaia added a commit to matiasgarciaisaia/verboice-asterisk that referenced this issue Jul 27, 2020
It's needed to set the correct public IP in the `o=` line of the SIP INVITE - which some providers ask for.

See instedd/verboice#877
@matiasgarciaisaia
Copy link
Member Author

To sum this up: the config was auto-written, indeed. It simply was done in a different repo - so we fixed this in instedd/verboice-asterisk#1 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant