Support Africa's Talking callSessionState parameter
#895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysbaddaden
approved these changes
Oct 22, 2021
AfT now sends a `callSessionState` parameter on every request. This used to only appear when calls were already completed, so we were aborting the calls. We now look for the `completed` state only. See #894
matiasgarciaisaia
force-pushed
the
preview/africas-talking-callsessionstate
branch
from
871aede to
ce65cb5
Compare
|
We were able to use this version to perform a couple of calls in Uganda, and it worked OK - ship it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AfT now sends a
callSessionStateparameter on every request.This used to only appear when calls were already completed, so we were aborting the calls. We now look for the
completedstate only.See #894