Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove DCO Checks from all InstructLab repositories #192

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

courtneypacheco
Copy link
Contributor

This document proposes the removal of explicit DCO checks from all InstructLab repositories. If explicit DCO checks are removed, then contributors no longer have to "sign off" each commit.

Copy link

@ktdreyer ktdreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Courtney! I support this idea because

  • Several editors (like GitHub's web UI) do not add these lines to commit logs.
  • New contributors do not always have advanced Git knowledge to amend commit messages.
  • The DCO Bot sometimes has outages, delaying merging PRs.

Signed-off-by: Courtney Pacheco <6019922+courtneypacheco@users.noreply.github.com>
@nathan-weinberg nathan-weinberg requested a review from a team February 20, 2025 16:22
@jjasghar
Copy link
Member

I thought the DCO thing was from Red Hat/IBM Legal. I strongly suggest we get legal entities to sign off on this before we continue moving forward.

Copy link
Member

@jjasghar jjasghar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment above.

@booxter
Copy link

booxter commented Feb 25, 2025

I believe legal did sign off on this, but @ktdreyer could share specific snippet I guess.

@ktdreyer
Copy link

I've checked with RH Legal on this and they've agreed to this change.

@jjasghar
Copy link
Member

Not that I don't trust you, but I we need some level of paper trail with this. @lhawthorn can you advise here? I'm not comfortable signing off on this as an OC committee member without seeing the paper trail.

@lhawthorn
Copy link
Member

It is a requirement from the legal team. Following up via real time chat, will summarize outcome in this PR.

@lhawthorn
Copy link
Member

Hi Folks, after a long session of hashing out in real time chat about legal requirements and the DCO, I am asking that we keep DCO for any submissions to the taxonomy repo, as removing it has significant implications for the community model rebuild work.

I leave it to other folks who are focused on the workflow for InstructLab mechanics vs. contributions to the community model build to understand if there are further implications to removing the DCO from other repos, but I do not immediately identify them.

Pinging also @instructlab/ui-maintainers because the DCO is part of their UI workflow and this change will possibly have implications for them.

@markstur
Copy link
Member

  • Several editors (like GitHub's web UI) do not add these lines to commit logs.

The org has sign-off via web ui enabled so it should be just a checkbox.

@markstur
Copy link
Member

There is an alternative CLA process so that contributors agree that they have agreed to the contributor agreement. It is much worse than DCO sign-off.

@vishnoianil
Copy link
Member

Pinging also @instructlab/ui-maintainers because the DCO is part of their UI workflow and this change will possibly have implications for them.

UI has DCO workflow because taxonomy requires DCO, even if taxonomy doesn't require it in future, we can still keep signing-off the commits, because UI does the signoff on behalf of the user. To contribute to the UI project itself, it can adopt any guidelines.

In my humble opinion, signoffs and CLAs are considered best practices. Signoff enforces that user have a Name on the profile and primary email address. Incase user is unresponsive (may be filtering github notifications) we can reach out through email address if requires. It gives an alternate communication channel apart from github comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants