Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more consistent with OOP/functional programming #187

Open
RobotSail opened this issue Nov 21, 2024 · 0 comments
Open

Be more consistent with OOP/functional programming #187

RobotSail opened this issue Nov 21, 2024 · 0 comments

Comments

@RobotSail
Copy link
Member

There seems to currently be a mixture of OOP principles as well as functional principles throughout the codebase. Some of these seem like they can be combined.

For example, MMLUEvaluator implements all common functionality in a base abstract class which its variants then inherit.

However; MTBench seems to implement some base methods in the class, but also call out to generate_answers functionally, which seems counterintuitive to intended functionality.

def generate_answers(

We should combine this into the existing abstract class or make everuthing functional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant