This repository was archived by the owner on Sep 9, 2025. It is now read-only.
schema: Move schema files into a versioned folder #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
hickeyma
suggested changes
Mar 28, 2024
Member
hickeyma
left a comment
hickeyma
left a comment
There was a problem hiding this comment.
Looking good @bjhargrave. Just some small nits.
To prepare for future updates to the schema, we use a versioned folder. Then downstream users, such as cli, can use the schema file from the versioned folder(s) which the user understands. This will also allow users to support and validate documents from older schema versions. We also add the version property to the schema. This is supported by cli from instructlab/instructlab#417. The version property is not required for version 1. Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prepare for future updates to the schema, we use a versioned folder. Then downstream users, such as cli, can use the schema file from the versioned folder(s) which the user understands. This will also allow users to support and validate documents from older schema versions.
We also add the version property to the schema. This is supported by cli from instructlab/instructlab#417. The version property is not required for version 1.