Use GEMINI_JSON as default

instructor-ai · Dec 27, 2024 · 25045ab · 25045ab
1 parent 887316c
commit 25045ab
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/docs/concepts/patching.md b/docs/concepts/patching.md
@@ -35,6 +35,7 @@ Gemini tool calling comes with some known limitations:
     - Gemini tool calling is incompatible with Pydantic schema customizations such as examples due to API limitations and may result in errors
     - Gemini can sometimes call the wrong function name, resulting in malformed or invalid json
     - Gemini tool calling could fail with enum and literal field types
+    - Gemini tool calling doesn't preserve the order of the fields in the response. Don't rely on the order of the fields in the response.
 
 ```python
 import instructor
@@ -45,7 +46,7 @@ client = instructor.from_gemini(
 )
 ```
 
-### Gemini Vertex AI Tool Callin
+### Gemini Vertex AI Tool Calling
 
 This method allows us to get structured output from Gemini via tool calling with the Vertex AI SDK.
 

diff --git a/instructor/client_gemini.py b/instructor/client_gemini.py
@@ -11,24 +11,26 @@
 @overload
 def from_gemini(
     client: genai.GenerativeModel,
-    mode: instructor.Mode = instructor.Mode.GEMINI_TOOLS,
+    mode: instructor.Mode = instructor.Mode.GEMINI_JSON,
     use_async: Literal[True] = True,
     **kwargs: Any,
-) -> instructor.AsyncInstructor: ...
+) -> instructor.AsyncInstructor:
+    ...
 
 
 @overload
 def from_gemini(
     client: genai.GenerativeModel,
-    mode: instructor.Mode = instructor.Mode.GEMINI_TOOLS,
+    mode: instructor.Mode = instructor.Mode.GEMINI_JSON,
     use_async: Literal[False] = False,
     **kwargs: Any,
-) -> instructor.Instructor: ...
+) -> instructor.Instructor:
+    ...
 
 
 def from_gemini(
     client: genai.GenerativeModel,
-    mode: instructor.Mode = instructor.Mode.GEMINI_TOOLS,
+    mode: instructor.Mode = instructor.Mode.GEMINI_JSON,
     use_async: bool = False,
     **kwargs: Any,
 ) -> instructor.Instructor | instructor.AsyncInstructor: