Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify multimodal fix #1054

Closed
wants to merge 2 commits into from
Closed

Verify multimodal fix #1054

wants to merge 2 commits into from

Conversation

ivanleomk
Copy link
Collaborator

@ivanleomk ivanleomk commented Oct 9, 2024

This just checks pipeline


Important

Update convert_contents and convert_messages to handle custom dictionary content in multimodal pipeline, with new test case added.

  • Functionality:
    • Update convert_contents in multimodal.py to handle dict types, allowing custom dictionary content.
    • Update convert_messages in multimodal.py to support the changes in convert_contents.
  • Testing:
    • Add test_convert_contents_custom_dict in test_multimodal.py to verify handling of custom dictionary content.

This description was created by Ellipsis for f34d108. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f34d108 in 18 seconds

More details
  • Looked at 63 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. tests/test_multimodal.py:190
  • Draft comment:
    Unnecessary conversion to list. convert_contents already returns a list when input is a dictionary or list.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The test test_convert_contents_custom_dict is incorrectly converting a dictionary to a list before asserting. The convert_contents function should return a list, so the conversion to a list is unnecessary and misleading.
2. tests/test_multimodal.py:185
  • Draft comment:
    The test suite is updated to include test_convert_contents_custom_dict, which is necessary due to changes in the library code to handle dictionaries in convert_contents. This ensures the new functionality is tested.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The test function test_convert_contents_custom_dict is newly added, which is a change in the test suite. This is appropriate since the library code was modified to handle dictionaries in convert_contents. The test suite is updated accordingly, which is good practice.

Workflow ID: wflow_DemU1yguW4RlK0D2


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Deploying instructor with  Cloudflare Pages  Cloudflare Pages

Latest commit: f34d108
Status: ✅  Deploy successful!
Preview URL: https://602ed781.instructor.pages.dev
Branch Preview URL: https://verify-multimodal-fix.instructor.pages.dev

View logs

@ivanleomk ivanleomk closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant