Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update example to use file_path arg; reflecting updated BatchJob.create_from_messages #1096

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

goutham794
Copy link
Contributor

@goutham794 goutham794 commented Oct 18, 2024

Important

Fix incorrect role from "system" to "user" in JSON example in batch.md.

  • Documentation:
    • Fix incorrect role from "system" to "user" in JSON example in batch.md.

This description was created by Ellipsis for 1d8f224. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 1d8f224 in 7 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. docs/cli/batch.md:99
  • Draft comment:
    The change from "role": "system" to "role": "user" is correct. The message content is a user request, so the role should be user. Ensure this change is consistent across similar examples.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change from 'system' to 'user' in the role field is appropriate given the context of the message content, which is a user request for classification.

Workflow ID: wflow_9ACZN6DZYEfr9Z1B


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@goutham794 goutham794 changed the title docs: fix wrong role in messages in batch file eg. docs: update example to use file_path arg; reflecting updated BatchJob.create_from_messages Oct 18, 2024
@jxnl jxnl merged commit 4065cc0 into instructor-ai:main Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants