Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added requests as a dependency #1102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ivanleomk
Copy link
Collaborator

@ivanleomk ivanleomk commented Oct 21, 2024

This adds requests as a dependency. Since we're using requests in Image.from_url and Audio.from_url, we should make this an explicit dependency


Important

Add requests as a dependency in pyproject.toml to support Image.from_url and Audio.from_url.

  • Dependencies:
    • Add requests version ^2.32.3 to pyproject.toml dependencies to support Image.from_url and Audio.from_url functions.

This description was created by Ellipsis for debfa25. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to debfa25 in 9 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pyproject.toml:23
  • Draft comment:
    The addition of 'requests' as a dependency is appropriate given its usage in the codebase. Ensure that the version specified is compatible with other dependencies.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR correctly adds 'requests' as a dependency in the pyproject.toml file. This aligns with the PR description stating that 'requests' is used in Image.from_url and Audio.from_url functions. No issues found with this addition.
2. pyproject.toml:23
  • Draft comment:
    Since 'requests' has been added as a dependency, ensure that the documentation is updated to reflect this change.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The addition of the 'requests' library as a dependency is a change to the library code. Therefore, the documentation should be updated to reflect this change.

Workflow ID: wflow_CxmsBUiWvleL7hRk


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Deploying instructor-py with  Cloudflare Pages  Cloudflare Pages

Latest commit: debfa25
Status: ✅  Deploy successful!
Preview URL: https://5bfeaea4.instructor-py.pages.dev
Branch Preview URL: https://add-request-dep.instructor-py.pages.dev

View logs

@ivanleomk ivanleomk requested a review from jxnl October 21, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant