Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-text-input): icon in SimpleSelect is vertically centered #1696

Conversation

ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Sep 24, 2024

Closes: INSTUI-4226

TEST PLAN:

  • copy the following code to the code editor of the documentation:
<SimpleSelect
  defaultValue="option-1"
  renderLabel="Option Icons"
  renderBeforeInput={<IconCommonsLine />}
>
  <SimpleSelect.Option id="opt1" value="option-1">
    Option one
  </SimpleSelect.Option>
</SimpleSelect>
  • inspect the parent span of the svg element, and in Developer Tools>Styles, hover the mouse over align-items: center to check if the icon is vertically aligned
  • previously the icon wasn't vertically centered

@ToMESSKa ToMESSKa self-assigned this Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-02 11:38 UTC

@ToMESSKa ToMESSKa requested review from matyasf and balzss September 25, 2024 07:23
@ToMESSKa ToMESSKa marked this pull request as ready for review September 25, 2024 07:24
@ToMESSKa ToMESSKa merged commit 13790d1 into master Oct 2, 2024
11 checks passed
@ToMESSKa ToMESSKa deleted the INSTUI-4226_icon_of_render_before_input_is_not_vertically_centered_for_simple_select_components branch October 2, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants