INSTUI-4322 Make it possible to not use global theme registry. Deprecate global theme registry. #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
matyasf
force-pushed
the
deprecate_globalthis
branch
from
4d59415 to
7aab574
Compare
matyasf
changed the title
matyasf
commented
Nov 11, 2024
| @@ -69,3 +74,4 @@ const __theme: CanvasTheme = { | |||
| const theme = ThemeRegistry.registerTheme(__theme) | |||
|
|
|||
| export default theme | |||
There was a problem hiding this comment.
This is the main change and what we will recommend people to use
matyasf
changed the title
balzss
approved these changes
Nov 22, 2024
HerrTopi
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to make it possible to run InstUI v8/v9 in the same page as InstUI v10 when the host app uses the older version and a later initialized one v10.
Currently this causes the v10 app to look buggy because
ThemeRegistrywill return an incompatible v8 theme object:in
canvas.ts:in
ThemeRegistry.registerTheme:This PR makes it possible to get the theme directly circumventing
ThemeRegistryand its theme cache. Also deprecatesThemeRegistry(which is used for global themes)