Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-date-time-input,ui-form-field): make DateTimeInput compatible with the new error format #1834

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

matyasf
Copy link
Collaborator

@matyasf matyasf commented Dec 19, 2024

Backport of INSTUI-4405 from the v10 branch Github PR #1826

TEST PLAN:

  • check the datetimeinput examples in the error forms guide
  • setting the isRequired prop should display two separate asterisks for each field
  • when required and displaying an error, the asterisks should turn red
  • the errors should be displayed under the input field like it was a single field and not a group

…with the new error format

Backport of INSTUI-4405 from the v10 branch Github PR #1826
TEST PLAN:
- check the datetimeinput examples in the error forms guide
- setting the isRequired prop should display
two separate asterisks for each field
- when required and displaying an error, the asterisks should
turn red
- the errors should be displayed under the input field like it
was a single field and not a group
@matyasf matyasf requested a review from balzss December 19, 2024 13:03
@matyasf matyasf self-assigned this Dec 19, 2024
@matyasf matyasf requested a review from HerrTopi December 19, 2024 13:03
Copy link

github-actions bot commented Dec 19, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-19 14:13 UTC

Copy link
Contributor

@balzss balzss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@matyasf matyasf merged commit 064a1a9 into v9_maintenance Dec 19, 2024
6 checks passed
@matyasf matyasf deleted the datetimeinput_error_msg_v9 branch December 19, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants