Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move commitizen config to commitlint; #1835

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

balzss
Copy link
Contributor

@balzss balzss commented Dec 19, 2024

also removed cz-lerna-changelog pkg and skip commit hook on rebase and amend

update:package:list and commit:package:list was removed from package.json as I wasn't able to figure out why they were needed (probably legacy usecase)

the package instui-config was removed too as it isn't serving any purpose anymore

test plan:

  • check out the branch and make any change and commit it -> check if the prompt works as intended
  • make a change 2 different packages -> check if scopes are correctly calculated
  • in the scope select menu, select more then 3 packages -> the final messages should display many as the scope
  • char limit should be 150 -> after the prompt, extend the message over the limit -> commitlint should give an error
  • amend a commit -> prompt should not appear
  • rebase the branch -> prompt should not appear

@balzss balzss self-assigned this Dec 19, 2024
@balzss balzss requested review from HerrTopi and matyasf and removed request for HerrTopi December 19, 2024 13:42
Copy link

github-actions bot commented Dec 19, 2024

PR Preview Action v1.5.0
Preview removed because the pull request was closed.
2025-01-08 16:15 UTC

@balzss balzss force-pushed the chore/improve-git-hooks branch from 890bb9e to 0b585ca Compare December 20, 2024 11:18
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice work! there is something off with the package-lock.json, when i run npm i it generates some changes. I think you just need to do this and commit it.

Also for whatever reason npm does not delete our old packages from package-lock.json, but leaves them there with an extraneous=true prop. If I delete these entries they are gone for good, can you please do this?

@balzss balzss force-pushed the chore/improve-git-hooks branch from 0b585ca to 3285995 Compare January 6, 2025 15:24
@HerrTopi
Copy link
Contributor

HerrTopi commented Jan 7, 2025

very nice work! there is something off with the package-lock.json, when i run npm i it generates some changes. I think you just need to do this and commit it.

Also for whatever reason npm does not delete our old packages from package-lock.json, but leaves them there with an extraneous=true prop. If I delete these entries they are gone for good, can you please do this?

This should have a better solution than manually managing the package lock, shouldn't it?

@balzss balzss requested a review from matyasf January 7, 2025 20:08
@balzss balzss merged commit 7273c3a into master Jan 8, 2025
10 of 11 checks passed
@balzss balzss deleted the chore/improve-git-hooks branch January 8, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants