fix(ui-source-code-editor): link label to input field programmatically #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ToMESSKa
commented
Feb 7, 2025
| @@ -655,7 +665,7 @@ class SourceCodeEditor extends Component<SourceCodeEditorProps> { | |||
| omitProps(restProps, SourceCodeEditor.allowedProps) | |||
| )} | |||
| > | |||
| <label css={styles?.label} htmlFor={this._id}> | |||
| <label css={styles?.label} id={this._id}> | |||
There was a problem hiding this comment.
htmlFor does not work for div elements and the textbox is a div element in CodeMirror so replaced with id
ToMESSKa
changed the title
ToMESSKa
commented
Feb 7, 2025
| @@ -644,6 +645,15 @@ class SourceCodeEditor extends Component<SourceCodeEditorProps> { | |||
| } | |||
| } | |||
|
|
|||
| assignAriaLabel = () => { | |||
| if (this._containerRef) { | |||
| const editorDiv = this._containerRef.querySelector('[role="textbox"]') | |||
There was a problem hiding this comment.
because the CodeMirror does not provide any way to reach this element, I had to find it like this
There was a problem hiding this comment.
An alternative way to find textbox is to go through child elements of the containerRef if it is an element but this is good as well.
joyenjoyer
approved these changes
Feb 10, 2025
ToMESSKa
deleted the
INSTUI-4289_source_code_editor_provide_visual_labels_for_the_souce_code_editor_example_in_the_docs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: INSTUI-4289
ISSUE: SourceCodeEditor label is not linked to the input field pragmatically. Therefore screenreader does not read the label when tabbed into the input field
TEST PLAN: