Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial naive implementation #1

Merged
merged 12 commits into from
Jun 24, 2022
Merged

Initial naive implementation #1

merged 12 commits into from
Jun 24, 2022

Conversation

xDarksome
Copy link
Contributor

No description provided.

@xDarksome xDarksome self-assigned this Jun 20, 2022
@xDarksome xDarksome requested a review from tyranron June 20, 2022 13:56
@tyranron tyranron added feature New feature or request k::design Related to overall design and/or architecture k::api Related to API (application interface) labels Jun 21, 2022
tyranron
tyranron requested changes Jun 21, 2022
View reviewed changes
tyranron
tyranron reviewed Jun 21, 2022
View reviewed changes
@ilslv
Copy link

ilslv commented Jun 21, 2022

It looks like [alias] sections allows to define only cargo aliases. To do something else we'll need to use cargo-make or something similar, which is less portable, than plain old Makefile.

@xDarksome xDarksome requested a review from tyranron June 22, 2022 09:28
tyranron
tyranron requested changes Jun 22, 2022
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xDarksome good, but E2E tests require some polishing.

@xDarksome xDarksome requested a review from tyranron June 24, 2022 09:51
@tyranron tyranron merged commit 5957b6a into main Jun 24, 2022
@tyranron tyranron deleted the initial-naive-implementation branch June 24, 2022 10:30
@tyranron tyranron added this to the 0.1.0 milestone Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@xDarksome xDarksome

Labels
feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@xDarksome @ilslv @tyranron