Feat/close instruments #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sort of addresses #215. I can add an actual |
|
Sorry for the delay Looks reasonable to me I need to fix CI but then I'll get your PR merged in: #374 |
scasagrande
requested changes
Nov 1, 2022
tests/test_base_instrument.py
Outdated
| @@ -8,6 +8,8 @@ | |||
|
|
|||
| import socket | |||
| import io | |||
| import unittest | |||
| from instruments.abstract_instruments import instrument | |||
There was a problem hiding this comment.
please sort and group imports
There was a problem hiding this comment.
Shouldn't have these import there in the first place. Good catch.
Codecov Report
@@ Coverage Diff @@
## main #376 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 87 87
Lines 8849 8855 +6
=======================================
+ Hits 8762 8768 +6
Misses 87 87
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Gracecr
force-pushed
the
feat/close-instruments
branch
from
d021392 to
398bf1f
Compare
scasagrande
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for instruments to be used as context managers so you can do things like:
This way you can be confident your connection is being closed properly.