Dressler Cesar 1312 RF generator #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- most background functions roughly implemented and tested. - turning RF on and off is implemented and tested - Lots of todos and fixmes around for renaming, refractoring, simplyfing
Not fully covered yet in terms of tests, some errors, etc. still unchecked
|
all seems reasonable to me is the test failure something py38 specific? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
+ Coverage 98.61% 99.13% +0.51%
==========================================
Files 89 90 +1
Lines 8962 9127 +165
==========================================
+ Hits 8838 9048 +210
+ Misses 124 79 -45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Was mostly 3.8 specific due to typing issue, plus one issue that failed in 3.9, should be fixed now. 3.8 is EOL, but that's a separate issue ;) |
scasagrande
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's support for the Dressler Cesar 1312 RF generator. An older instrument, but works great via RS232. The most important commands are implemented and especially the package sending/receiving are working very well. Functionality that is covered:
Test coverage included, added to docs.
Curious to hear your opinion @scasagrande. There is no dedicated RF generator, so inheriting from Instruments. Might be something to think about...