Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Assets.format
optionalformat_column_name
toESMDataSource
's initESMDataSource
's internal df.xarray_open_kwargs
are generated independently for each assets (instead of only once).Related issue number
Checklist
To make this PR simple, I decided to use an hardcoded name for the new column (
_data_format_
). Is this dangerous? It could be a column name stored in another variable, or the series could be independent from the main dataframe? The latter seems dangerous too.I added a sample collection that has 4 assets of CMIP6. 2 assets are from Google Storage (zarr) and the 2 others are local files. This has the bonus to also test that
to_dataset_dict
also works with remote and local assets within the same dataset.