Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose pd.DataFrame.to_csv and json.dump keyword arguments #421

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Expose pd.DataFrame.to_csv and json.dump keyword arguments #421

merged 2 commits into from
Dec 17, 2021

Conversation

andersy005
Copy link
Member

@andersy005 andersy005 commented Dec 17, 2021 •
edited
Loading

Change Summary

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

@andersy005
Copy link
Member Author

@aulemahal, let me know if this is good enough and/or whether I missed anything...

@andersy005 andersy005 added the enhancement Issues that are found to be a reasonable candidate feature additions label Dec 17, 2021
aulemahal
aulemahal approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! this is exactly what I was thinking about. Thanks!

@andersy005
Copy link
Member Author

Awesome! Thank you for the feedback!

@andersy005 andersy005 changed the title Expose to_csv and json.dump keyword arguments Expose pd.DataFrame.to_csv and json.dump keyword arguments Dec 17, 2021
@andersy005 andersy005 merged commit 18d9d57 into main Dec 17, 2021
@andersy005 andersy005 deleted the add-to-csv-kwargs branch December 17, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

Assignees
No one assigned
Labels
enhancement Issues that are found to be a reasonable candidate feature additions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to write uncompressed catalogs
2 participants
@andersy005 @aulemahal