Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure global attributes added by intake-esm are compatible with netCDF and Zarr #509

Merged
merged 4 commits into from
Aug 23, 2022
Merged

Ensure global attributes added by intake-esm are compatible with netCDF and Zarr #509

merged 4 commits into from
Aug 23, 2022

Conversation

andersy005
Copy link
Member

@andersy005 andersy005 commented Aug 22, 2022 •
edited
Loading

Change Summary

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

@andersy005 andersy005 requested a review from mgrover1 August 22, 2022 20:34
@andersy005
Copy link
Member Author

@aulemahal, when you get a moment, can you take a look at this and let me know if you have any feedback?

mgrover1
mgrover1 approved these changes Aug 23, 2022
View reviewed changes
Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for putting this together @andersy005

intake_esm/source.py Show resolved Hide resolved
aulemahal
aulemahal approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for solving these issues!

@aulemahal aulemahal mentioned this pull request Aug 23, 2022
Closed
@andersy005
Copy link
Member Author

thank you for the feedback , @aulemahal & @mgrover1

@andersy005 andersy005 merged commit ba4bb59 into main Aug 23, 2022
@andersy005 andersy005 deleted the fix-attrs branch August 23, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrover1 mgrover1 mgrover1 approved these changes

@aulemahal aulemahal aulemahal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@andersy005 @aulemahal @mgrover1