_yaml method for stac obj #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jhamman Can you approve the workflow? |
|
@scottyhq and @martindurant - if you have a minute to take a look here, your review would be appreciated. To review, the goal here is to enabling serialization of intake-stac objects. Things got complicated because intake-stac maintains a reference to underlying stac objects which, requires some careful packing/unpacking. |
| @@ -354,7 +363,7 @@ def __init__(self, key, asset): | |||
| name=key, | |||
| description=asset.title, | |||
| driver=driver, | |||
| direct_access=True, | |||
| direct_access='allow', | |||
There was a problem hiding this comment.
In hindsight, this is far from obvious! It won't matter to anyone not running an Intake server.
|
Thanks again for working on this @jukent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per NASA-ACCESS work with @jhamman
This PR makes it so
.yaml()will accept a stac-obj and create a YAML that includes all of the data for its assets.Recreation of #103 in a safe branch.
One file (
sandbox.ipynb) will be removed before push.