Build wheel using cibuildwheel #103
Conversation
work for linux and macos, initial for windows
|
I can't personally help with the Windows thing. Perhaps someone else can. |
|
@martindurant I read a little and it is now building windows wheel above 3.5. |
|
@martindurant I'm an active contributor to |
|
What would trigger an actual upload to pypi, a new git tag? I notice that a lot of files were moved around such as snappy/snappy.py → src/snappy/snappy.py; this, for me, beraks the typical pydata package layout, so I wonder whether it is necessary. |
| runs-on: ubuntu-latest | ||
| name: upload wheels | ||
| needs: ['sdist', 'build'] | ||
| if: startsWith(github.ref, 'refs/tags/0.') |
There was a problem hiding this comment.
here is the upload trigger
this is because the test grabs a snappy folder instead of the content of the snappy package. The previous workflow delete files to prevent this. I strongly prefer Maybe the other solution could be a move test (which also should not be in a top lever directory). |
| - name: Clean up sources | ||
| # this cleans up the sources to make sure `import snappy` uses the wheel | ||
| # an alternative would be to run pytest in a different working directory | ||
| run: rm -rf setup.py ./snappy |
There was a problem hiding this comment.
here is the reason of move to src.
|
Maybe nice to read: https://iscinumpy.gitlab.io/post/overview-of-cibuildwheel/ In a few days, I will try to use the newest |
|
Thanks @Czaki , and glad to see you still pushing this |
split linux build on two jobs
|
It looks ready. Current PR builds 71 wheels:
list of current wheels: |
|
Thanks @Czaki |
|
There is a plan to upload the whole set of wheels in a short time? |
|
If you tell me how! :) |
|
Without a new release, you could download artifacts from the bottom of the build page https://github.com/andrix/python-snappy/actions/runs/572119475 and then use twine to upload (you need to filter out already uploaded wheels)
|
|
Lots of wheels uploaded |
Closes #93
This PR build wheel for Linux and macOS.
Its build wheel for CPython 2.7, 3.5-9. PyPy 2.7, 3.6, 3.7 for Linux 32 bits/64 bits and macOS.
It builds CPython 3.5-9 pypy3.6, pypy3.7 for windows.
When
cibuilwheel2.0 was released then also macOSuniversal2could be a simple build.This PR move source code to
srcto avoid name collision when executing tests.