This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
Intly 3888 #7
Merged
Intly 3888 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenairn
reviewed
Nov 26, 2019
Makefile
Outdated
|
|
||
| .PHONY: code/fix | ||
| code/fix: | ||
| @gofmt -w `find . -type f -name '*.go' -not -path "./vendor/*"` |
There was a problem hiding this comment.
The code/check and code/fix targets are in here twice
|
@maleck13 The Also need to prioritise getting this added to CI, think @pmccarthy might take that on to share the love on the CI front. |
mikenairn
approved these changes
Nov 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes include a basic set of tests for some of functionality. It updates some of the dependencies and fixes some bugs found while testing